Skip to content

[docker-in-docker]-docker_compose-fallback-github api - #914

Merged
Samruddhi Khandale (samruddhikhandale) merged 8 commits into
devcontainers:mainfrom
gauravsaini04:docker-in-docker_docker-compose_github_api_fallback
Mar 26, 2024
Merged

[docker-in-docker]-docker_compose-fallback-github api#914
Samruddhi Khandale (samruddhikhandale) merged 8 commits into
devcontainers:mainfrom
gauravsaini04:docker-in-docker_docker-compose_github_api_fallback

Conversation

@gauravsaini04

Copy link
Copy Markdown
Contributor

Feature name:

  • Docker-In-Docker

Description:

This PR introduces the following functionality:

  • When the latest tag for docker-compose doesn't have a source binary released yet, then it will continue installing the previous working version for which a source binary will be available using these 2 methods:
    • Using github api if rate limit hasn't expired
    • Using get_prev_version_from_git_tags function which is written locally to fetch previous git tags

Changelog:

  • Updated install.sh
  • Updated tests to validate that when a dummy docker-compose version is tried to be downloaded with curl command thus representing trying to access a source binary which is not deployed yet, then will pick up the binary for the tag which will eventually work successfully from either of the two methods mentioned above.

Checklist:

  • Checked that applied changes work as expected

Comment thread src/docker-in-docker/install.sh
Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, left some minor comments.

Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated
Comment thread src/docker-in-docker/install.sh Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks wonderful! Thank you so much.

@samruddhikhandale
Samruddhi Khandale (samruddhikhandale) merged commit 0100f66 into devcontainers:main Mar 26, 2024
@gauravsaini04
Gaurav Saini (gauravsaini04) deleted the docker-in-docker_docker-compose_github_api_fallback branch March 27, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants